[AutoImport] Do not add cast on valid Integer type on Name Node on au…

…to import enabled (#6236)

* [AutoImport] Do not add cast on valid Integer type on Name Node on auto import enabled

* add ClassConstFetchTypeResolver

* Fix phpstan

* Fix phpstan

* typo fix

* add failing fixture on static call

* fix

* clean up

src/DependencyInjection/LazyContainerFactory.php

@@ -80,6 +80,7 @@
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver\CastTypeResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver\ClassAndInterfaceTypeResolver;
+use Rector\NodeTypeResolver\NodeTypeResolver\ClassConstFetchTypeResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver\ClassMethodOrClassConstTypeResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver\IdentifierTypeResolver;
 use Rector\NodeTypeResolver\NodeTypeResolver\NameTypeResolver;
@@ -345,6 +346,7 @@ final class LazyContainerFactory
         NewTypeResolver::class,
         ParamTypeResolver::class,
         PropertyFetchTypeResolver::class,
+        ClassConstFetchTypeResolver::class,
         PropertyTypeResolver::class,
         ScalarTypeResolver::class,
         TraitTypeResolver::class,

src/NodeTypeResolver/NodeTypeResolver/ClassConstFetchTypeResolver.php

@@ -0,0 +1,54 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\NodeTypeResolver\NodeTypeResolver;
+
+use PhpParser\Node;
+use PhpParser\Node\Expr\ClassConstFetch;
+use PhpParser\Node\Name;
+use PhpParser\Node\Name\FullyQualified;
+use PHPStan\Analyser\Scope;
+use PHPStan\Type\MixedType;
+use PHPStan\Type\Type;
+use Rector\NodeTypeResolver\Contract\NodeTypeResolverInterface;
+use Rector\NodeTypeResolver\Node\AttributeKey;
+
+/**
+ * @implements NodeTypeResolverInterface<ClassConstFetch>
+ */
+final class ClassConstFetchTypeResolver implements NodeTypeResolverInterface
+{
+    /**
+     * @return array<class-string<Node>>
+     */
+    public function getNodeClasses(): array
+    {
+        return [ClassConstFetch::class];
+    }
+
+    /**
+     * @param ClassConstFetch $node
+     */
+    public function resolve(Node $node): Type
+    {
+        $scope = $node->getAttribute(AttributeKey::SCOPE);
+
+        if (! $scope instanceof Scope) {
+            return new MixedType();
+        }
+
+        if ($node->class instanceof FullyQualified) {
+            return $scope->getType($node);
+        }
+
+        if ($node->class instanceof Name && $node->class->hasAttribute(AttributeKey::NAMESPACED_NAME)) {
+            $newNode = clone $node;
+            $newNode->class = new FullyQualified($node->class->getAttribute(AttributeKey::NAMESPACED_NAME));
+
+            return $scope->getType($newNode);
+        }
+
+        return $scope->getType($node);
+    }
+}

src/NodeTypeResolver/NodeTypeResolver/NameTypeResolver.php

@@ -37,6 +37,11 @@ public function getNodeClasses(): array
      */
     public function resolve(Node $node): Type
     {
+        // not instanceof FullyQualified means it is a Name
+        if (! $node instanceof FullyQualified && $node->hasAttribute(AttributeKey::NAMESPACED_NAME)) {
+            return $this->resolve(new FullyQualified($node->getAttribute(AttributeKey::NAMESPACED_NAME)));
+        }
+
         if ($node->toString() === ObjectReference::PARENT) {
             return $this->resolveParent($node);
         }

tests/Issues/AutoImport/Fixture/do_not_add_cast_valid_int_type_from_name.php.inc

@@ -0,0 +1,37 @@
+<?php
+
+namespace Rector\Tests\Issues\AutoImport\Fixture;
+
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+
+class DoNotAddCastValidIntTypeFromName extends Command
+{
+    private ?OutputInterface $outputInterface = null;
+
+    protected function execute(InputInterface $input, OutputInterface $output): int
+    {
+        return Command::SUCCESS;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Issues\AutoImport\Fixture;
+
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+
+class DoNotAddCastValidIntTypeFromName extends Command
+{
+    protected function execute(InputInterface $input, OutputInterface $output): int
+    {
+        return Command::SUCCESS;
+    }
+}
+
+?>

tests/Issues/AutoImport/Fixture/do_not_add_cast_valid_int_type_from_name2.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+namespace Rector\Tests\Issues\AutoImport\Fixture;
+
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Rector\Tests\Issues\AutoImport\Source\SomeClass;
+
+class DoNotAddCastValidIntTypeFromName2 extends Command
+{
+    private ?OutputInterface $outputInterface = null;
+
+    protected function execute(InputInterface $input, OutputInterface $output): int
+    {
+        return SomeClass::zero();
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Issues\AutoImport\Fixture;
+
+use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+use Rector\Tests\Issues\AutoImport\Source\SomeClass;
+
+class DoNotAddCastValidIntTypeFromName2 extends Command
+{
+    protected function execute(InputInterface $input, OutputInterface $output): int
+    {
+        return SomeClass::zero();
+    }
+}
+
+?>

tests/Issues/AutoImport/Source/SomeClass.php

@@ -6,4 +6,8 @@
 
 class SomeClass
 {
+    public static function zero(): int
+    {
+        return 0;
+    }
 }

tests/Issues/AutoImport/config/configured_rule.php

@@ -7,6 +7,8 @@
 use Rector\Php80\Rector\Class_\AnnotationToAttributeRector;
 use Rector\Php80\ValueObject\AnnotationToAttribute;
 use Rector\Renaming\Rector\Name\RenameClassRector;
+use Rector\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector;
+use Rector\Symfony\Symfony44\Rector\ClassMethod\ConsoleExecuteReturnIntRector;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->importNames();
@@ -18,4 +20,8 @@
     $rectorConfig->ruleWithConfiguration(AnnotationToAttributeRector::class, [
         new AnnotationToAttribute('Doctrine\ORM\Mapping\Entity'),
     ]);
+    $rectorConfig->rules([
+        ConsoleExecuteReturnIntRector::class,
+        RemoveUnusedPrivatePropertyRector::class,
+    ]);
 };