[Php70] Fix with \r\n on EregToPregMatchRector (#6246)

* Add CRLF test case for EregToPregMatchRector * Closes #6245 * Closes #6245 --------- Co-authored-by: Michael McEniry <mcenirm@mceniry.net>
rectorphp · Aug 21, 2024 · c3f5cbc · c3f5cbc
1 parent 98f6159
commit c3f5cbc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/rules-tests/Php70/Rector/FuncCall/EregToPregMatchRector/Fixture/fixture3.php.inc b/rules-tests/Php70/Rector/FuncCall/EregToPregMatchRector/Fixture/fixture3.php.inc
@@ -9,6 +9,8 @@ function eregToPregMatch3()
     split('hi', 'hi, she said', 0);
 
     spliti('hi', 'hi, she said', 1);
+
+    split("\r\n", "line 1\r\nline 2\r\n");
 }
 
 ?>
@@ -24,6 +26,8 @@ function eregToPregMatch3()
     preg_split('#hi#m', 'hi, she said', 1);
 
     preg_split('#hi#mi', 'hi, she said', 1);
+
+    preg_split("#\r\n#m", "line 1\r\nline 2\r\n");
 }
 
 ?>
diff --git a/rules/Php70/Rector/FuncCall/EregToPregMatchRector.php b/rules/Php70/Rector/FuncCall/EregToPregMatchRector.php
@@ -22,6 +22,7 @@
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\Php70\Rector\FuncCall\EregToPregMatchRector\EregToPregMatchRectorTest
@@ -111,7 +112,8 @@ private function processStringPattern(FuncCall $funcCall, String_ $string, strin
         $pattern = $this->eregToPcreTransformer->transform($pattern, $this->isCaseInsensitiveFunction($functionName));
 
         $firstArg = $funcCall->getArgs()[0];
-        $firstArg->value = new String_($pattern);
+        Assert::isInstanceOf($firstArg->value, String_::class);
+        $firstArg->value->value = $pattern;
     }
 
     private function processVariablePattern(FuncCall $funcCall, Variable $variable, string $functionName): void