[CodeQuality] Allow transform static to self on final class on ConvertStaticPrivateConstantToSelfRector #6295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tStaticPrivateConstantToSelfRector
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
@TomasVotruba let's merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On non-final class, it only works on private constant, see
https://3v4l.org/rPYm0 vs https://3v4l.org/80571
This rule currently only works on private constant https://getrector.com/demo/5c3ff3fc-8b61-45d1-acab-2bb3f974f3af
On Final class, it can actually should works on private, protected, and public as no child to read:
see https://3v4l.org/7TGlv
so this PR add this ability
Closes rectorphp/rector#8818