kafkabp: Metrics cleanup #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove statsd metrics, and some tweaks to prometheus metrics to better align with prometheus naming convention (use plural form for units). For rebalances, since success rebalances happen so rare (consumer rebalances just happen so rare in general, not that we rarely success), the vectored version will cause rate to not really report anything >0, so split that into total and failures_total instead. For the rack id failures, an internal code search shows that the http one is not used by anything and the aws one is only used by 3 repos, so I opted against keep both and deprecate the old one, and will notify the repo owners instead.
fishy
requested review from
kylelemons,
pacejackson and
mterwill
and removed request for
a team
kylelemons
approved these changes
Nov 1, 2022
pacejackson
approved these changes
Nov 1, 2022
mterwill
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove statsd metrics, and some tweaks to prometheus metrics to better align with prometheus naming convention (use plural form for units).
For rebalances, since success rebalances happen so rare (consumer rebalances just happen so rare in general, not that we rarely success), the vectored version will cause rate to not really report anything >0, so split that into total and failures_total instead.
For the rack id failures, an internal code search shows that the http one is not used by anything and the aws one is only used by 3 repos, so I opted against keep both and deprecate the old one, and will notify the repo owners instead.