thriftbp: Metrics cleanup #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
pacejackson and
ghirsch-reddit
and removed request for
a team
fishy
force-pushed
the
thriftbp-metrics-cleanup
branch
from
e62d1ee
to
bc97a85
Compare
Remove statsd metrics, and rename some prometheus metrics to comply with prometheus naming convention. For renamed prometheus metrics, temporarily emitting both old and new, but mark old ones as deprecated to be removed later. Also remove some statsd only features: 1. CountedServerTransport is marked as deprecated and no longer used by other code. 2. In ReportPayloadSizeMetrics server middleware, the rate arg is deprecated and the prometheus metrics is always reported. 3. ClientPoolConfig.MetricsTags & ClientPoolConfig.ReportPoolStats are deprecated. The pool stats are always reported as prometheus metrrics.
fishy
force-pushed
the
thriftbp-metrics-cleanup
branch
from
bc97a85
to
b5cc9f1
Compare
ghirsch-reddit
approved these changes
Nov 1, 2022
fishy
commented
Nov 1, 2022
| }, panicRecoverLabels) | ||
|
|
||
| panicRecoverCounter = promauto.With(prometheusbpint.GlobalRegistry).NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "thriftbp_server_recovered_panics_total", |
There was a problem hiding this comment.
technically (according to some dictionaries) "panic" is uncountable as a noun, but I think we pretty much use it as countable noun in go.
fishy
added a commit
to fishy/baseplate.go
that referenced
this pull request
Nov 1, 2022
Remove/deprecate statsd metrics, and rename an httpbp prometheus metrics similar to the thriftbp one in reddit#581.
fishy
added a commit
to fishy/baseplate.go
that referenced
this pull request
Nov 1, 2022
Remove/deprecate statsd metrics, and rename an httpbp prometheus metrics similar to the thriftbp one in reddit#581.
kylelemons
approved these changes
Nov 2, 2022
fishy
added a commit
to fishy/baseplate.go
that referenced
this pull request
Nov 2, 2022
Remove/deprecate statsd metrics, and rename an httpbp prometheus metrics similar to the thriftbp one in reddit#581.
fishy
added a commit
that referenced
this pull request
Nov 2, 2022
Remove/deprecate statsd metrics, and rename an httpbp prometheus metrics similar to the thriftbp one in #581.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove statsd metrics, and rename some prometheus metrics to comply with prometheus naming convention. For renamed prometheus metrics, temporarily emitting both old and new, but mark old ones as deprecated to be removed later.
Also remove some statsd only features: