secrets: Fix bug about not wait for secrets.json to become available #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
pacejackson and
ghirsch-reddit
and removed request for
a team
pacejackson
approved these changes
Nov 16, 2022
kylelemons
approved these changes
Nov 16, 2022
secrets/store_test.go
Outdated
Comment on lines
497
to
498
| writeDelay = time.Second / 5 | ||
| timeout = time.Second * 5 |
There was a problem hiding this comment.
Suggested change
| writeDelay = time.Second / 5 | |
| timeout = time.Second * 5 | |
| writeDelay = 200*time.Millisecond | |
| timeout = 5*time.Second |
When we added support for CSI directories, we introduced a bug that we no longer wait for secrets.json to become available, because os.Stat call would fail with file not exist error immediately. Since in CSI directories case the directory would be guaranteed to be available immediately (unlike the vault case), assume file not exist errors from os.Stat as using file instead of directory, and let filewatcher.New to handle the waiting as before. Also add a test for it. While I'm here, also remove the usages of os.IsNotExist and os.IsExist follow the docs.
fishy
force-pushed
the
secrets-init-bug-fix
branch
from
a7cee85
to
3691c77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added support for CSI directories, we introduced a bug that we no longer wait for secrets.json to become available, because os.Stat call would fail with file not exist error immediately.
Since in CSI directories case the directory would be guaranteed to be available immediately (unlike the vault case), assume file not exist errors from os.Stat as using file instead of directory, and let filewatcher.New to handle the waiting as before. Also add a test for it.
While I'm here, also remove the usages of os.IsNotExist and os.IsExist follow the docs.