errorsbp: Update for go 1.20 #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested review from
kylelemons,
pacejackson and
ghirsch-reddit
and removed request for
a team
fishy
force-pushed
the
errorsbp-go-1-20
branch
from
abf37cb
to
8508710
Compare
pacejackson
requested changes
Jan 5, 2023
| return batch | ||
| }(), | ||
| }, | ||
| // TODO: Add cases from errors.Join and fmt.Errorf once we drop support for |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
pacejackson
approved these changes
Jan 5, 2023
kylelemons
approved these changes
Jan 5, 2023
fishy
force-pushed
the
errorsbp-go-1-20
branch
from
66f3606
to
d16649d
Compare
Go 1.20 is going to add native support for batched/multi errors, and we will be able to eventually deprecate errorsbp.Batch, but we can only do so after we dropped support for go 1.19. Before that, make errorsbp.Batch play nicer with go 1.20 by: * Implement the new `Unwrap() []error` optional interface. * Make errorsbp.BatchSize also support other errors implementing the new optional interface.
fishy
force-pushed
the
errorsbp-go-1-20
branch
from
d16649d
to
7643c5c
Compare
ghirsch-reddit
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.20 is going to add native support for batched/multi errors, and we will be able to eventually deprecate errorsbp.Batch, but we can only do so after we dropped support for go 1.19.
Before that, make errorsbp.Batch play nicer with go 1.20 by:
Unwrap() []erroroptional interface.