make secrets.Store middleware threadsafe #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacejackson
requested review from
fishy,
kylelemons and
konradreiche
and removed request for
a team
fishy
approved these changes
Jul 27, 2023
secrets/testing.go
Outdated
| @@ -4,7 +4,6 @@ import ( | |||
| "bytes" | |||
| "context" | |||
| "encoding/json" | |||
|
|
|||
There was a problem hiding this comment.
nit: don't remove this blank line
There was a problem hiding this comment.
Weird... not sure where that came from
fishy
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
Guard secrets.Store middleware with a mutex to make adding new middlewares to an existing store threadsafe.
📜 Details
Sometimes we have to call
AddMiddlewarein a goroutine which can lead to race conditions with other calls toAddMiddleware. Adding a mutex around updating and calling the middleware functions protects us from this.✅ Checks