Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudServiceAccountRequestController should recreate secret if deleted #83

Open
wtrocki opened this issue Feb 23, 2021 · 5 comments
Open
Milestone

Comments

@wtrocki
Copy link
Collaborator

wtrocki commented Feb 23, 2021

If MSAR deleted then-secret should be deleted.
If Secret is deleted then the MSAR controller recreates that.

We should remove the service account in MAS-SSO

@wtrocki wtrocki added this to the Operator Summit milestone Feb 23, 2021
@secondsun secondsun self-assigned this Mar 31, 2021
@wtrocki wtrocki removed this from the Operator Summit milestone Apr 9, 2021
@secondsun secondsun changed the title MSAR should recreate secret if deleted CloudServiceAccountRequestController should recreate secret if deleted Apr 14, 2021
@secondsun
Copy link
Contributor

@pmuir Since we are limiting users to two serviceaccounts, should we delete the service account also now too?

@secondsun secondsun removed their assignment Apr 14, 2021
@pmuir
Copy link
Collaborator

pmuir commented Apr 15, 2021

I don't think this temporary limitation on service accounts should change our logic.

@wtrocki
Copy link
Collaborator Author

wtrocki commented Apr 15, 2021

So we will be increasing limits to more than 2 per user after some time?
We have issue to improve error message for limits in #174
In the error message we probably need to send URL for users to remove them, but I found that if we keep limit for 2 then there is very little margin for users even in eval phase. If someone does something wrong in the namespace usually we would ask them to try again in the other namespace, but in this situation this will be another service account (probably hitting the limit).

If we would get 3-4 service accounts per user we could avoid possible problems.
When working on summit we could simply tell someone to remove resource and try again. But if service account stays then we need to redirect them to UI to remove them etc. (more convoluted flow)

@wtrocki
Copy link
Collaborator Author

wtrocki commented Apr 15, 2021

Ok. Creating separate issue to provide troubleshooting documentation. Aka your Own Kafka with 2 service accounts help :D

@wtrocki wtrocki added this to the 0.8.0 milestone Apr 23, 2021
@wtrocki
Copy link
Collaborator Author

wtrocki commented May 14, 2021

This is on hold for long time and is causing bug when resource is deleted making it hard to cleanup things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants