Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate switching type tests to Vitest #4122

Closed
EskiMojo14 opened this issue Jan 25, 2024 · 2 comments
Closed

Investigate switching type tests to Vitest #4122

EskiMojo14 opened this issue Jan 25, 2024 · 2 comments
Labels
enhancement New feature or request typescript

Comments

@EskiMojo14
Copy link
Collaborator

Vitest provides its own suite for testing types, which would be good to switch our tests over to.

We need to make sure we can get the same checks and safety, but it looks like toEqualTypeOf is equivalent to expectExactType and toMatchTypeOf is equivalent to expectType.
@EskiMojo14 EskiMojo14 added enhancement New feature or request typescript labels Jan 25, 2024
@EskiMojo14 EskiMojo14 mentioned this issue Jan 25, 2024
Closed
1 task
@aryaemami59
Copy link
Contributor

From my experience toEqualTypeOf and expectExactType don't seem to be 100% interchanchable. toEqualTypeOf seems to be slightly more strict/accurate than expectExactType but I could be wrong. I can go ahead and get started on the conversion.

@EskiMojo14
Copy link
Collaborator Author

I think stricter is okay - less strict would be bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EskiMojo14 @aryaemami59