Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include commit_message body in pr_body #1713

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

jakirkham
Copy link
Contributor

Improve visibility of additional details from the commit_message by including in the migrator PR's body message.

Improve visibility of additional details from the `commit_message` by
including in the migrator PR's body message.
@jakirkham
Copy link
Contributor Author

FWIW usage like this case ( conda-forge/conda-forge-pinning-feedstock#4527 ) is one situation that might benefit from this added visibility.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (dfb0b30) 68.14% compared to head (40e070d) 68.15%.

❗ Current head 40e070d differs from pull request most recent head 1d4f06f. Consider uploading reports for the commit 1d4f06f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1713      +/-   ##
==========================================
+ Coverage   68.14%   68.15%   +0.01%     
==========================================
  Files          90       90              
  Lines        8494     8501       +7     
==========================================
+ Hits         5788     5794       +6     
- Misses       2706     2707       +1     
Impacted Files Coverage Δ
conda_forge_tick/migrators/migration_yaml.py 59.92% <0.00%> (+0.07%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@beckermr beckermr merged commit 592fbee into regro:master Jun 14, 2023
@jakirkham jakirkham deleted the add_migrator_custom_pr_msg branch June 14, 2023 22:56
@jakirkham
Copy link
Contributor Author

Thanks Matt! 🙏

Copy link
Contributor Author

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry missed some newlines below. Fixed with PR ( #1714 )

conda_forge_tick/migrators/migration_yaml.py Show resolved Hide resolved
conda_forge_tick/migrators/migration_yaml.py Show resolved Hide resolved
@jakirkham jakirkham mentioned this pull request Jun 14, 2023
@carterbox
Copy link

Nice! This is what I expected to happen in the first place because GitHub does this when you open a PR for a branch with a single commit. Thanks, @jakirkham!

@jakirkham
Copy link
Contributor Author

Happy to help 🙂

Yeah it may be missed as we push 2 commits with these migrators or because the PR body is set

In any event think your PR adding the commit message got at the core issue 🙏

The rest of this is just tinkering around the edges 😉


FWIW there's an example of what this looks like here: conda-forge/conda-forge-pinning-feedstock#4527 (comment)

We can probably tweak it more. Though it does feel like we've got the basic pieces in place 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants