Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't fail on external broken link #19

Closed
dialex opened this issue Feb 15, 2018 · 3 comments
Closed

Doesn't fail on external broken link #19

dialex opened this issue Feb 15, 2018 · 3 comments
Labels
🙋 no/question This does not need any changes

Comments

@dialex
Copy link
Contributor

dialex commented Feb 15, 2018

Urls such as...

...do not return warnings or errors. I was not expecting this.

So this tool only validates links to internal pages? If that's so, it should be made explicit.

@wooorm
Copy link
Member

wooorm commented Feb 15, 2018

@dialex Correct, that’s not supported, there are other tools that do that. Could you create a PR that makes the docs more clear?

@dialex
Copy link
Contributor Author

dialex commented Feb 15, 2018

Done @wooorm. Can you recommend me a tool to check for broken external links?

@wooorm
Copy link
Member

wooorm commented Feb 15, 2018

Should be something here! https://github.com/remarkjs/remark-lint#list-of-external-rules

I’ll close this for now, we can discuss the PR on it’s own page (but I’ll do that later)

@wooorm wooorm closed this as completed Feb 15, 2018
@dialex dialex changed the title Doesn't fail on not found URL Doesn't fail on external broken link Dec 27, 2018
@wooorm wooorm added the 🙋 no/question This does not need any changes label Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 no/question This does not need any changes
Development

Successfully merging a pull request may close this issue.

2 participants