Maven - Update patch version only even for old versions #17629

mathieu-amblard · 2022-09-05T08:26:59Z

mathieu-amblard
Sep 5, 2022

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us what version of Renovate you run.

32.185.1

If you're self-hosting Renovate, select which platform you are using.

Bitbucket Server

If you're self-hosting Renovate, tell us what version of the platform you run.

GitLab

Was this something which used to work for you, and then stopped?

I never saw this working

Describe the bug

I am new to Renovate and I would like to update only patch versions of Spring dependencies.
So, I have created a simple package rule like this :

{
   "matchPackagePrefixes": ["org.springframework:", "org.springframework.boot:"],
   "matchUpdateTypes": ["major", "minor"],
   "enabled": false
}

It works well, if the dependency has the latest minor version, eg : org.springframework.boot:spring-boot-dependencies:2.7.1 then it is is correctly updated to org.springframework.boot:spring-boot-dependencies:2.7.3.
But if my dependency has an oldest minor version, eg : org.springframework.boot:spring-boot-dependencies:2.6.4, then it is not updated.
It is working only if I set the flag separateMinorPatch to true but it this case I have two pull requests, I wanted only one.
Maybe I am missing some configuration ?
Thank you in advance for your help.

Relevant debug logs

It seems that Renovate does not keep the patch dependencies :

Logs

DEBUG: Found 364 new releases for org.springframework.boot:spring-boot-dependencies in repository ...
...
DEBUG: http statistics
       "urls": {
...
        ".../org/springframework/boot/spring-boot-dependencies/2.6.0/spring-boot-dependencies-2.6.0.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.1/spring-boot-dependencies-2.6.1.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.10/spring-boot-dependencies-2.6.10.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.11/spring-boot-dependencies-2.6.11.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.2/spring-boot-dependencies-2.6.2.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.3/spring-boot-dependencies-2.6.3.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.4/spring-boot-dependencies-2.6.4.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.5/spring-boot-dependencies-2.6.5.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.6/spring-boot-dependencies-2.6.6.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.7/spring-boot-dependencies-2.6.7.pom (HEAD,200)": 1,
        ".../org/springframework/boot/spring-boot-dependencies/2.6.8/spring-boot-dependencies-2.6.8.pom (HEAD,200)": 1,
        "...org/springframework/boot/spring-boot-dependencies/2.6.9/spring-boot-dependencies-2.6.9.pom (HEAD,200)": 1,
...
}
...
DEBUG: packageFiles with updates
       "config": {
         "maven": [
           {
             "datasource": "maven",
             "packageFile": "pom.xml",
             "deps": [
                  {
                    "datasource": "maven",
                    "depName": "org.springframework.boot:spring-boot-dependencies",
                    "currentValue": "2.6.4",
                    "fileReplacePosition": 432,
                    "registryUrls": ["https://repo.maven.apache.org/maven2"],
                    "depType": "parent",
                    "depIndex": 0,
                    "updates": [
                      {
                        "bucket": "latest",
                        "newVersion": "2.7.3",
                        "newValue": "2.7.3",
                        "releaseTimestamp": "2022-08-18T06:29:49.000Z",
                        "newMajor": 2,
                        "newMinor": 7,
                        "updateType": "minor",
                        "branchName": "renovate/master-maven"
                      }
                    ],
                    "warnings": [],
                    "versioning": "maven",
                    "sourceUrl": "https://github.com/spring-projects/spring-boot",
                    "homepage": "https://spring.io/projects/spring-boot",
                    "currentVersion": "2.6.4",
                    "isSingleVersion": true,
                    "fixedVersion": "2.6.4"
                  }
...

Have you created a minimal reproduction repository?

No reproduction repository

rarkins · 2022-09-05T09:11:07Z

rarkins
Sep 5, 2022
Maintainer

If you are new to Renovate, please limit yourself to Discussions in future. I have converted your bug report to this Discussion and deleted the original, but it wastes my time unnecessarily each time I need to do it or type messages like this.

It sounds like you're looking for the config option separateMinorPatch.

3 replies

mathieu-amblard Sep 5, 2022
Author

Thank you for your reply and sorry for wasting your time,
If you read correctly the description of the bug, then you will see that I have already tried the config option separateMinorPatch but this is not what I wanted... I want only one PR for minor and patch updates to reduce noise.
By replying like this, you won't encourage people to use your product... I thought that was a bug that's why I added it as a bug as it seems to be a common use case but ok let's continue it as a Discussion.
So, how can I update patch versions only of a specific maven dependency ?

rarkins Sep 5, 2022
Maintainer

If you use the package rule in your question (which disables major and minor) along with separateMinorPatch then you should get only one PR, because the patch one will be allowed while the minor will be disabled. If this is not what you're seeing, please make a public reproduction to demonstrate (automated instructions will follow below).

mathieu-amblard Sep 5, 2022
Author

Thank you for your reply,
Sorry I was not clear enough about having multiple PRs.

Personally, when I want to update all the dependencies of my component, I would like to have all the updates in only one PR to check :

if new dependencies do not contain breaking changes
if they are compatibles
if the build passed
I know by experience that for some dependencies such as Spring that minor versions can contain breaking changes that's why I wanted to exclude them.

For example, let suppose that I have these two dependencies :

org.apache.commons:commons-lang3:3.11.0 and the version 3.12.0 is available
org.springframework.boot:spring-boot-starter:2.6.4 and the versions 2.6.11 and 2.7.3 are available

After running Renovate, I expect to have in only one PR with these changes :

org.apache.commons:commons-lang3:3.12.0
org.springframework.boot:spring-boot-starter:2.6.11

Actually, by adding separateMinorPatch, I get one PR for :

org.apache.commons:commons-lang3:3.12.0

And one for :

org.springframework.boot:spring-boot-starter:2.6.11

If I do not add separateMinorPatch, I get only one PR for :

org.apache.commons:commons-lang3:3.12.0

Can you please tell me if this is possible ?
I will also try to create a minimal reproduction if needed.

2022-09-05T11:01:56Z

github-actions[bot]
bot Sep 5, 2022

Hi there,

Get your issue fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction.

We may close the issue if you, or someone else, haven't created a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

0 replies

mathieu-amblard · 2022-09-05T12:36:05Z

mathieu-amblard
Sep 5, 2022
Author

Here is the minimal reproduction : https://github.com/mathieu-amblard/renovate-17629
Here is the PR generated : https://github.com/mathieu-amblard/renovate-17629-test/pulls
Thank you in advance for your help

7 replies

rarkins Sep 6, 2022
Maintainer

This is currently intended/expected behavior due to this code logic:

renovate/lib/workers/repository/updates/branch-name.ts

Lines 67 to 69 in ca5be4b

    
           if (update.updateType === 'patch' && update.separateMinorPatch) { 
        
             update.groupSlug = `patch-${update.groupSlug}`; 
        
           }

Otherwise if both patch and minor updates existed then there'd be no way to separate them (if you put both patch and minor updates for the same dependency into one branch, the minor would take precedence).

i.e. if you have separateMinorPatch enabled and grouping, you will get separate PRs for patch updates and minor updates.

mathieu-amblard Sep 6, 2022
Author

I agree but in my case I explicitly want to ignore minor versions for some dependencies so I expect to have only patch updates and not both.
I think the logic is not too complicated, Renovate has to retrieve the latest major, minor and patch version. Then if I disable major and minor updates and set separateMinorPatch=false, it should only retrieve the patch update and add it to the same PR. If I do not disable minor update then I agree I both patch and minor updates exist then I should have only the minor update and this is what I expect too.
As I wrote before, I would like to have all updates into one PR to check if the dependencies are still compatible.

rarkins Sep 6, 2022
Maintainer

If you think you can solve this problem, submit a PR to the code base

mathieu-amblard Sep 6, 2022
Author

This is not what I have written... It seems that you already have all the information to do this...
Why not for submitting a PR when I will have more time but I am not really sure that I want to contribute to your project....

viceice Sep 6, 2022
Maintainer

this scenarion is currently not solvable with those config options and will probably never / not easily solvable.

viceice · 2022-09-06T05:41:20Z

viceice
Sep 6, 2022
Maintainer

please try allowed version filter instead of disabling major and minor updates.

https://docs.renovatebot.com/configuration-options/#allowedversions

6 replies

mathieu-amblard Sep 6, 2022
Author

Thank you for the information, I will try this configuration option and will let you know.

mathieu-amblard Sep 6, 2022
Author

allowedVersions works well if I have only one branch.
Is it possible to capture groups in matchCurrentVersion and reuse them in allowedVersions ?

viceice Sep 6, 2022
Maintainer

no

mathieu-amblard Sep 6, 2022
Author

Worst support I have ever seen... really a pity because you have a really great product.

mathieu-amblard Sep 6, 2022
Author

You can mark the discussion as resolved or simply remove it... I will not disturb you again...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maven - Update patch version only even for old versions #17629

{{title}}

Replies: 4 comments 16 replies

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Maven - Update patch version only even for old versions #17629

mathieu-amblard Sep 5, 2022

How are you running Renovate?

If you're self-hosting Renovate, tell us what version of Renovate you run.

If you're self-hosting Renovate, select which platform you are using.

If you're self-hosting Renovate, tell us what version of the platform you run.

Was this something which used to work for you, and then stopped?

Describe the bug

Relevant debug logs

Have you created a minimal reproduction repository?

Replies: 4 comments · 16 replies

rarkins Sep 5, 2022 Maintainer

mathieu-amblard Sep 5, 2022 Author

rarkins Sep 5, 2022 Maintainer

mathieu-amblard Sep 5, 2022 Author

github-actions[bot] bot Sep 5, 2022

mathieu-amblard Sep 5, 2022 Author

rarkins Sep 6, 2022 Maintainer

mathieu-amblard Sep 6, 2022 Author

rarkins Sep 6, 2022 Maintainer

mathieu-amblard Sep 6, 2022 Author

viceice Sep 6, 2022 Maintainer

viceice Sep 6, 2022 Maintainer

mathieu-amblard Sep 6, 2022 Author

mathieu-amblard Sep 6, 2022 Author

viceice Sep 6, 2022 Maintainer

mathieu-amblard Sep 6, 2022 Author

mathieu-amblard Sep 6, 2022 Author

mathieu-amblard
Sep 5, 2022

Replies: 4 comments 16 replies

rarkins
Sep 5, 2022
Maintainer

mathieu-amblard Sep 5, 2022
Author

rarkins Sep 5, 2022
Maintainer

mathieu-amblard Sep 5, 2022
Author

github-actions[bot]
bot Sep 5, 2022

mathieu-amblard
Sep 5, 2022
Author

rarkins Sep 6, 2022
Maintainer

mathieu-amblard Sep 6, 2022
Author

rarkins Sep 6, 2022
Maintainer

mathieu-amblard Sep 6, 2022
Author

viceice Sep 6, 2022
Maintainer

viceice
Sep 6, 2022
Maintainer

mathieu-amblard Sep 6, 2022
Author

mathieu-amblard Sep 6, 2022
Author

viceice Sep 6, 2022
Maintainer

mathieu-amblard Sep 6, 2022
Author

mathieu-amblard Sep 6, 2022
Author