Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle resolver argument in pip-compile manager #18488

Closed
mkniewallner opened this issue Oct 23, 2022 · 1 comment · Fixed by #18489
Closed

Handle resolver argument in pip-compile manager #18488

mkniewallner opened this issue Oct 23, 2022 · 1 comment · Fixed by #18489
Labels
manager:pip-compile Related to pip compile package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)

Comments

@mkniewallner
Copy link
Contributor

What would you like Renovate to be able to do?

pip-tools 6.8.0 added a --resolver argument that can take 2 values:

  • backtracking, which makes pip-tools use pip's 2020 dependency resolver
  • legacy (the default value for now), which makes pip-tools use pip's legacy resolver

Support for the legacy resolver will be deprecated and removed at some point (this is tracked in jazzband/pip-tools#1659), mostly because pip itself will remove support for the old resolver.

There are 2 main reasons for supporting this argument in Renovate:

  • this is an argument that is now used by multiple projects
  • once a new version of pip-tools defaulting to backtracking resolver is used by Renovate, users will be forced to use the new resolver, even if they explicitly set the value to legacy (or use an older version of pip-tools)

If you have any ideas on how this should be implemented, please tell us here.

The implementation should be rather straightforward, as Renovate should simply read --resolver argument and, if set, sanitise it to ensure that it is either legacy or backtracking (and avoid unsecure inputs), then pass it as an argument to pip-tools.

Is this a feature you are interested in implementing yourself?

Yes

@mkniewallner mkniewallner added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Oct 23, 2022
@viceice viceice added manager:pip-compile Related to pip compile package manager status:ready priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage labels Oct 24, 2022
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 34.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:pip-compile Related to pip compile package manager priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants