-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super errors broke vscode tasks problem matchers #3446
Comments
The current super_errors setup is very imperative. I think this is a valid feature request, I will add an environment variable support to avoid super_errors |
Thanks @bobzhang ! I was going to propose to add the |
I really don’t think we should add more env vars for these things, especially since we own the task matcher. Also, it’s pretty backward to disable super errors just because a regex didn’t pass. |
In general, we need a way to turn super-error on and off, I planned to add a flag |
The problem matcher is limited (it still can not handle multiple line properly). We recommend editor plugins dome some program API based on .compiler.log. |
The project themes included in bsb contain some VSCode tasks with problem matchers. For example, in
basic-reason
theme:https://github.com/BuckleScript/bucklescript/blob/3cf3133a4978df05e0b5fb351a1d2d18dce16c32/jscomp/bsb/templates/basic-reason/.vscode/tasks.json#L24-L39
These matchers used to work fine in the past, when bsb was showing OCaml-like errors like:
but they break with super error format. This format is nicer for console errors, but really hard to parse from another program through regexps (see
ocaml-lang-server
handling as an example).Would there be a way to pass an extra flag to bsb (even if it's only in watch mode) that would skip super errors and output the errors in the old format?
Adding this flag would be really useful to simplify the logic and responsibilities that Reason / OCaml vscode extensions need to do right now.
Also, going back to the OCaml format would be a big step to come up with problem matchers that can be shared between BuckleScript and Dune (for native projects). While in Dune the users have much more control (just don't use
refmterr
) in BuckleScript that's not the case.cc @chenglou
The text was updated successfully, but these errors were encountered: