holiday parameter in calendar_td()

[AQLT]

The parameter holiday in calendar_td() doesn't seem to be used:
https://github.com/jdemetra/jdplus-main/blob/cb327446048d9a3300f1e6b7b6a3765a4da98757/jdplus-main-base/jdplus-toolkit-base-parent/jdplus-toolkit-base-r/src/main/java/jdplus/toolkit/base/r/modelling/Variables.java#L63-L74
Maybe this line
https://github.com/jdemetra/jdplus-main/blob/cb327446048d9a3300f1e6b7b6a3765a4da98757/jdplus-main-base/jdplus-toolkit-base-parent/jdplus-toolkit-base-r/src/main/java/jdplus/toolkit/base/r/modelling/Variables.java#L65C114-L65C130
should be replaced by something like:

HolidaysCorrectedTradingDays.HolidaysCorrector corrector = HolidaysCorrectionFactory.corrector(calendar, DayOfWeek.of(dw));

[palatej]

Hi Alain,

I finally abandoned (for the moment) the idea of specifying the day corresponding to an holiday (normally Sunday) because the correct handling of such a feature generated a lot of problems (especially in long term mean corrections). So, it is unused for the time being. A warning could be sent to the user in R (or the parameter could be suppressed).

[TanguyBarthelemy]

Ok we will remove this parameter from the function calendar_td().

[AQLT]

The parameter can still be left with a comment saying that it is unused. It would then be easier to change it when it will be implemented in Java. This is for example what is done in some set_ functions

[TanguyBarthelemy]

Ok we will add a warning then.