-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quality indicators #45
Comments
I don't think it's possible. |
Thanks Tanguy, do you know of a way to compute this indicator myself? |
I also don't think it is currently exportable and if it is easy to modify the corresponding Java code. A solution (and maybe faster solution) could be to reimplement it in R defining your own thresholds and indicators. You can find the thresholds in JDemetra+ (in Windows Tools > Options > SA > X13 (for example) and double click on a diagnostic). The reference manual 2.2 indicates the following:
And then :
|
Thanks Alain, I know this description in the reference manual and it didn't really help me last time to replicate the JD+ quality indicator because it is very vague. |
I think they are the tests shown in the Main results panel |
Hi, |
In theory I would agree with you @annasmyk, but in practice few people actually know the thresholds and even fewer change the thresholds. Also, this indicator was exportable in V2 (so this is a regression), I think a lot of people look at it since it is highlighted in the interface, so it would be weird not to be able to export it. Changing the thresholds seems to have an effect on the "summary" statistic of the main results, but not on the "quality" diagnostic written when you select a SA processing. It doesn't seem to be exportable in v3 and in the cruncher of v3 (to be verified), so maybe @merangelik you should open an issue in https://github.com/jdemetra/jdplus-main? |
so the conclusion from my previous message is : it's doesn't necessarily make sense to make these indicators available in R, where your GUI parameters are unknown (unless always default) ..and I put a more detailed document about the computation here no worries I invited you to the stace shop organization |
I don't agree with you on this. For example, the description of rjd3toolkit is "Utility package for R access to JDemetra+ version 3.x algorithms", so the packages are related to what is present in the GUI and this statistic is calculated in "JDemetra+ version 3.x algorithms". Also, the "quality" diagnostic is independent of the GUI parameters, and this was exportable in v2, so it was considered important: since this diagnostic is important, this may be an obstacle for those who want to upgrade to v3. |
Or simply make the repo public as it is a documentation repo, that makes sense? |
I would like to add some precisions on this rather complex topic The GUI and R are just tools to access the core libraries. It means that they just give partial views of the core algorithms. Those views are not necessary identical; the packages are usually more general than the GUI (for instance, you can make canonical decomposition of models with any periodicity). The current limitations of the packages in comparison with the GUI are just a question of time or of opportunities. Now, concerning the "summary", I just added the code to export it (in the cruncher and in R). That will be pushed next week. Finally, I agree with Alain: you have all the tools to derive yourself your quality report. That's the solution I would prefer, by far |
Hi,
can I access the results used for the quality report without running the cruncher?
I am particularly interested in the "JD+ global quality assessment" indicator. Most of the remaining indicators I can derive from the output myself.
Btw, I am removing this issue from
rjdverse/rjd3workspace#21 (comment)
because I think it doesn't fit there anymore.
The text was updated successfully, but these errors were encountered: