Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of highcharts js #78

Closed
nesnoj opened this issue Jul 24, 2019 · 6 comments
Closed

Get rid of highcharts js #78

nesnoj opened this issue Jul 24, 2019 · 6 comments
Assignees
Labels
question Further information is requested urgent

Comments

@nesnoj
Copy link
Member

nesnoj commented Jul 24, 2019

As discussed yesterday, the highcharts src must be removed from repo as it conflicts with GPL:

Although Highsoft's software have open source codes, our software is not licensed
as an open source software and is unfortunately not compatible with any open
source software license like Apache 2 or any GPL

(source)

I do not like using external 3rd-party scripts as it 1) slows down the page, 2) can introduce malware etc. and 3) allows this party to track the usage. But I don't have a better solution right now.

I replaced the import from static files with official sources in StEmp ABW. I used v7.0.3 (same is in out static files) to make sure the app won't break in future hc releases.

@henhuy, StEmp MV has got multiple imports, could you replace them as well?
We do not have other apps which use hc, right?

BTW, foundation and jquery are MIT licensed so we don't run into problems by including the src..

@nesnoj nesnoj added question Further information is requested urgent labels Jul 24, 2019
@nesnoj
Copy link
Member Author

nesnoj commented Aug 27, 2019

Every second attempt to use StEmp ABW, the entire page lags or does not even show up (waiting for..) due to the external loading!
It's really annoying...

@henhuy
Copy link
Contributor

henhuy commented Aug 29, 2019

Ideas?

@nesnoj
Copy link
Member Author

nesnoj commented Aug 30, 2019

As just discussed on the phone, an alternative way is to

  • completely remove the HC js from WAM
  • keep the HC js files - completely independent from the WAM - somewhere on our webserver (with WAM IP access restriction) and obtain the files in the tools via https
  • add a config var which determines the files source (highcharts server or own server) or
    even better: tool checks if it's running on the WAM (e.g. using the IP or hostname) and uses the appropriate server - what do you think @henhuy?

@nesnoj
Copy link
Member Author

nesnoj commented Sep 3, 2019

Due to lack of time I cannot implement this. What about you @henhuy?
If not, I'd skip it for now

@nesnoj
Copy link
Member Author

nesnoj commented Sep 4, 2019

As soon as you switched to external HC (commit in StEmp ABW: rl-institut/WAM_APP_stemp_abw@0d32080), feel free to merge #85 and close this issue.

@nesnoj
Copy link
Member Author

nesnoj commented Sep 5, 2019

The described lags seem to be browser-related.
I like the local solution above but due to low priority I'll close this issue. Feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested urgent
Projects
None yet
Development

No branches or pull requests

2 participants