Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -CsrString parameter to New-PACertificate #503

Closed
ziptx opened this issue Jul 25, 2023 · 4 comments
Closed

Add -CsrString parameter to New-PACertificate #503

ziptx opened this issue Jul 25, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ziptx
Copy link

ziptx commented Jul 25, 2023

Fantastic product. Thank you for sharing this with the world.

The certificate work we are doing is completed through API calls. So, the CSR is actually already loaded and available in a string variable. The current version requires a path to a file for loading the CSR; hence the CSR needs to be written to disk vs being passed as a string. The code already exists to parse the CSR into the necessary data elements, we just need the mechanism to drop the CSR string into the function vs a file path.

@rmbolger rmbolger self-assigned this Jul 26, 2023
@rmbolger rmbolger added the enhancement New feature or request label Jul 26, 2023
@rmbolger
Copy link
Owner

Hey @ziptx, thanks for reaching out. This should definitely be doable. I'll try to get it into the next release.

@rmbolger
Copy link
Owner

rmbolger commented Aug 10, 2023

Hey @ziptx, have a look at PR #506 and let me know if that will work for your use-case. I'd also love it if you could grab the source from the allow-csrstring branch and test it. I may also roll it into the main branch over the next few days because it seems to be fairly solid so far. But I need to flesh out the help a bit first.

@rmbolger
Copy link
Owner

This is now live in 4.19.0.

@ziptx
Copy link
Author

ziptx commented Aug 28, 2023

Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants
@rmbolger @ziptx and others