-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CropAnnotator] - mark objects with zoomed in crop #786
Comments
Hello there! I would love to be assigned and implement that! A small correction at the description of the issue, the name of the annotator to be changed in |
@xaristeidou good luck and have fun :) |
The master of annotators is back in business 🔥! As for |
Hi @xaristeidou 👋🏻 Did you manage to get started with this task? |
@SkalskiP In fact yes! I dealt with some bugs in the meanwhile, and now are fixed. I have a question to get some different opinions on implementation. I have 2 different scenarios in mind. In cases where the cropped part of the image is going to exceed the scene dimensions based on the selected anchor
I would like to hear thoughts on that to continue further with a concept. Below I attach two examples for better representation. In both examples the anchor Scenario 1: Scenario 2: |
Hi @xaristeidou 👋🏻 ! It's awesome to see the progress. Let's go with scenario 1. It will be consistent with the behavior of other annotators. |
@SkalskiP Ok, when it is finished will get back with a PR. |
Hi @xaristeidou, 👋 |
Hi @xaristeidou 👋🏻 ! No worries! |
Fixed via #888 |
Description
Create
CropAnnotator
- whose task is to mark objects related tosv.Detections
with zoomed-in crops.Below is an example found on the internet. Of course, as part of this task, we would only add the part responsible for the crop.
The API should also allow for the selection of the location of the enlarged crop using
sv.Position
(above, below, ...), as well as the choice of thezoom_factor
.API
Additional
The text was updated successfully, but these errors were encountered: