Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ergocubwrist constraint in the joint mechanical specification #88

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Add ergocubwrist constraint in the joint mechanical specification #88

merged 2 commits into from
Oct 13, 2023

Conversation

valegagge
Copy link
Member

Here I added only one type of constraint the the jointset configuration.

This PR is useful for robotology/icub-firmware#424

@valegagge valegagge marked this pull request as draft October 10, 2023 12:59
@valegagge
Copy link
Member Author

valegagge commented Oct 10, 2023 •
edited
Loading

You can find the documentation of the new configuration here: robotology/robots-configuration#578

marcoaccame
marcoaccame approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@marcoaccame marcoaccame left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is OK, thanks. I will however merge when all the related PRs are ready.
Also, remember in icub-main to force the use of this version 1.36.2

@pattacini
Copy link
Member

Hi @valegagge

Does this PR have any impact on icub-main?

@valegagge
Copy link
Member Author

Hi @valegagge

Does this PR have any impact on icub-main?

nope

@valegagge valegagge marked this pull request as ready for review October 11, 2023 10:08
@marcoaccame
Copy link
Contributor

Hi @valegagge
Does this PR have any impact on icub-main?

nope

Yes, we can merge the PR even without the one in icub-firmware:

@marcoaccame marcoaccame merged commit ad732cf into robotology:devel Oct 13, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoaccame marcoaccame marcoaccame approved these changes

@davidetome davidetome Awaiting requested review from davidetome

@ale-git ale-git Awaiting requested review from ale-git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valegagge @pattacini @marcoaccame