Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embObjIMU: extend the possibility to handle also mtb3 and ems gyro/acc #894

Merged
merged 5 commits into from
Nov 23, 2023

Conversation

Nicogene
Copy link
Member

This PR implements the changes described here

With this change embObjInertials can be safely removed.

TO BE TESTED

Copy link
Member

@valegagge valegagge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nicogene added a commit to Nicogene/robots-configuration that referenced this pull request Nov 13, 2023
Nicogene added a commit to Nicogene/robots-configuration that referenced this pull request Nov 23, 2023
@Nicogene Nicogene marked this pull request as ready for review November 23, 2023 09:30
@Nicogene
Copy link
Member Author

This has been tested both w/ "legacy" and "new" boards (alone and mixed) and it works:

@pattacini pattacini merged commit a682008 into robotology:devel Nov 23, 2023
4 of 8 checks passed
@Nicogene Nicogene deleted the refactorEmbObjIMU branch November 23, 2023 13:55
Nicogene added a commit to Nicogene/icub-main that referenced this pull request Nov 27, 2023
This is possible since  now covers also the  functionalities (see robotology#894)
Nicogene added a commit to Nicogene/icub-main that referenced this pull request Nov 29, 2023
This is possible since  now covers also the  functionalities (see robotology#894)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants