ergoCub1.0 S/N:000 – Update and improve configuration files #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
pattacini
reviewed
May 15, 2023
This comment was marked as resolved.
This comment was marked as resolved.
sgiraz
changed the title
This was referenced May 15, 2023
Nicogene
reviewed
May 15, 2023
pattacini
reviewed
May 15, 2023
This comment was marked as resolved.
This comment was marked as resolved.
S-Dafarra
approved these changes
May 15, 2023
Nicogene
approved these changes
May 15, 2023
There was a problem hiding this comment.
In light of @AntonioConsilvio / @sgiraz clarifications lgtm now!
|
Let me merge this PR straight away. |
mfussi66
pushed a commit
to mfussi66/robots-configuration
that referenced
this pull request
Jun 19, 2023
MSECode
pushed a commit
to valegagge/robots-configuration
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new:
head-calib.xmlfor this issueright_arm-eb22-j7_10-mec.xmland "right_arm-eb22-j7_10-mc_service.xml" for this issueleft_arm-eb25-j11_12-mc_service.xmlfor this issue2FOCfirmware version is now aligned in the configuration files with the one actually installed on the robot.In addition, I added the original calibration order in a commented line for each calibration file; to avoid the risk of entering an incorrect calibration sequence in the event of temporary changes to the calibration order.
Notes:
This was done with the aim of reducing the number of files in the
ergoCubSN000configuration folder to make navigation easier and smoother. Please check among the deleted files whether they are still in use, as in that case they can be restored.cc @sgiraz @S-Dafarra @lrapetti @GiulioRomualdi @xEnVrE @mfussi66