Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ergoCub1.0 S/N000 – update left/right calib for startup and home position #524

Merged
merged 2 commits into from
May 22, 2023

Conversation

sgiraz
Copy link
Contributor

@sgiraz sgiraz commented May 22, 2023

What's new:

  • update startupPosition and homePosition in calibrators\left_arm-calib.xml with the min values set for jntPosMin in hardware\motorControl\left_arm-eb23-j7_10-mc.xml
  • update startupPosition and homePosition in calibrators\right_arm-calib.xml with the min values set for jntPosMin in hardware\motorControl\right_arm-eb22-j7_10-mc.xml

Note:

  • ⚠️ @AntonioConsilvio states that the jntPosMin parameter was set to 0 for the right arm since its joints can physically reach the 0 position. However, this is not the case for the left arm. Consequently, I adjusted the jntPosMin to 4 for the left arm to maintain consistency, considering it was already set to 4 for the right arm.
  • Probably the jntPosMin and jntPosMax values for both hands may be improved to be more accurate

cc @valegagge @MSECode @Nicogene

@sgiraz sgiraz self-assigned this May 22, 2023
@pattacini pattacini merged commit 860405c into robotology:devel May 22, 2023
@pattacini
Copy link
Member

pattacini commented May 22, 2023

jntPos[Min|Max] refer to the SW bounds, whereas hardwareJntPos[Min|Max] are the HW bounds.
It's important the latter coincides with the HW, while the former can be more restrictive.

mfussi66 pushed a commit to mfussi66/robots-configuration that referenced this pull request Jun 19, 2023
MSECode pushed a commit to valegagge/robots-configuration that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants