Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ergoCubSN001 - neck files updated #564

Merged
merged 10 commits into from
Sep 15, 2023
Merged

ergoCubSN001 - neck files updated #564

merged 10 commits into from
Sep 15, 2023

Conversation

davidetome
Copy link
Contributor

This PR updates XML files for the neck following tests on the setup

⚠️ This mod applies only to the pitch and roll of the neck, other joints of the head have to be calibrated as soon as available

cc @pattacini @sgiraz

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points need attention @davidetome.

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidetome 👍🏻
Awaiting the CI before merging.

@pattacini
Copy link
Member

pattacini commented Sep 6, 2023

CI still fails:

WARNING] ServiceParser::convert(): P3P is not a legal string for eObrd_connector_t
[WARNING] ServiceParser::parse_port_conn(): CONN:P3P is not a legal string for a eObrd_connector_t
[WARNING] ServiceParser::parse_actuator_port(): CONN:P3P is not a legal string for a pwm connector port
[ERROR] ServiceParser::check_motion() PROPERTIES.JOINTMAPPING.actuator.port not valid for item 0
[ERROR] ServiceParser::parseService() gets same errors parsing SERVICE MC group
[ERROR] embObjMC  BOARD head-eb20-j0_1 (IP 10.0.1.20)  cannot parse service
[ERROR] BOARD head-eb20-j0_1 (IP 10.0.1.20)  Missing motion control parameters in config file
[ERROR] |yarp.dev.PolyDriver|head-eb20-j0_1-mc| Driver <embObjMotionControl> was found but could not open

This is due to the fact that we haven't integrated yet the new FW/parser.
Thus, I'll keep this PR in draft and come back to it once the FW/parser is updated.

@pattacini pattacini marked this pull request as draft September 6, 2023 12:19
@pattacini
Copy link
Member

Thus, I'll keep this PR in draft and come back to it once the FW/parser is updated.

Awaiting the following PR to be merged before putting this in ready for review:

Copy link
Contributor

@sgiraz sgiraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davidetome, the PR is ok!

Copy link
Contributor

@marcoaccame marcoaccame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@pattacini
Copy link
Member

Required upstream PR merged ✅

I'm rebuilding the docker image used by the CI via https://github.com/robotology/robots-configuration/actions/runs/6198027673.

Once done, I'll put this PR in ready-for-review.

@pattacini pattacini marked this pull request as ready for review September 15, 2023 12:56
@pattacini pattacini merged commit a8d1df0 into robotology:devel Sep 15, 2023
1 of 2 checks passed
MSECode pushed a commit to valegagge/robots-configuration that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants