Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ergoCubSN001] Enable the temperature control for the robot legs and torso #621

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

GiulioRomualdi
Copy link
Member

This files are required to enable the temperature control for the ergoCubSN001 robot

cc @MSECode @valegagge @DanielePucci

@GiulioRomualdi GiulioRomualdi changed the title [ergoCubSN001] Enable the temperature control for the robot legs [ergoCubSN001] Enable the temperature control for the robot legs and torso Feb 29, 2024
Copy link
Contributor

@MSECode MSECode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Files changed are correct.
Upper arm of the robot has correctly remained unchanged since we are not enabling the temperature sensors there yet.

@pattacini
Copy link
Member

CI failure is unrelated and I'm tracking it down in #622.

Thanks @MSECode for the review 👍🏻
I was thinking if it is worth extending these changes to ergoCubSN002, at least.

@pattacini
Copy link
Member

I was thinking if it is worth extending these changes to ergoCubSN002, at least.

Would you mind opening a second PR for that, @MSECode?

I'm gonna merge this one.

@pattacini pattacini changed the base branch from master to devel February 29, 2024 16:44
@pattacini pattacini merged commit aad3460 into robotology:devel Feb 29, 2024
1 check failed
@pattacini
Copy link
Member

Merged in devel.

@GiulioRomualdi GiulioRomualdi deleted the ergocubsn001_temperature branch March 1, 2024 11:02
MSECode pushed a commit to valegagge/robots-configuration that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants