Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in local-workflow-tech #667

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

S-Dafarra
Copy link
Contributor

The remote to change is not origin but icub-tech

The remote to change is not ``origin`` but ``icub-tech``
@S-Dafarra S-Dafarra requested a review from pattacini July 8, 2024 14:12
@pattacini
Copy link
Member

Actually, the convention for remotes on a fork usually is:

  • origin: points to the fork repo on GH.
  • upstream: points to the upstream repo on GH.

I wasn't aware there was a remote called icub-tech, which would be peculiar to our system and not created at clone time.

@S-Dafarra
Copy link
Contributor Author

Actually, the convention for remotes on a fork usually is:

  • origin: points to the fork repo on GH.
  • upstream: points to the upstream repo on GH.

I wasn't aware there was a remote called icub-tech, which would be peculiar to our system and not created at clone time.

Actually, the repo gets cloned by the super build using robotology as origin. I thought it would be less error prone specifying a different remote name for the robot workflows only. This also enforces the good practice of not changing origin when adding a new fork to the repo

@pattacini
Copy link
Member

Actually, the repo gets cloned by the super build using robotology as origin.

I see, I missed this point.
Then, I would explain somewhere in the instructions that icub-tech is the remote pointing to the fork.

@pattacini
Copy link
Member

Then, I would explain somewhere in the instructions that icub-tech is the remote pointing to the fork.

It's already introduced here:

@pattacini pattacini merged commit 1183184 into robotology:devel Jul 8, 2024
fils99 pushed a commit to ami-iit/robots-configuration that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants