Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in v0.1.1 -> v0.1.2 break tool installation for some name formats #37

Closed
Corecii opened this issue Jul 13, 2024 · 0 comments · Fixed by #38
Closed

Changes in v0.1.1 -> v0.1.2 break tool installation for some name formats #37

Corecii opened this issue Jul 13, 2024 · 0 comments · Fixed by #38
Labels
bug Something isn't working

Comments

@Corecii
Copy link
Member

Corecii commented Jul 13, 2024

Changes between v0.1.1 and v0.1.2

System info:

PS C:\> rokit system-info
Paths:
  • Rokit dir   → ~/.rokit
  • Current dir → C:\
  • Current exe → ~/.rokit\bin\rokit.exe

System:
  • Windows X64
  • Rokit not in $PATH

Binaries:

Links:

(side note, I think it is actually in $PATH, it just isn't detected for some reason) 🤷‍♀️

Zip and bin name samples:
firefox_IEw1xgm8tJ
explorer_ZqwFrg1UUx


The name formats work well with aftman and with v0.1.1 of rokit. There is an issue for supporting more formats by handling matching and extraction better ( #4 ). This could be considered to fall under that, but could also be considered a bug, as it was probably unintended for this change to make rokit lose parity with aftman!

If you need access to one of the failing repos to test it, I can give you access to one. Just ask!

@Corecii Corecii added the bug Something isn't working label Jul 13, 2024
@Corecii Corecii changed the title v0.1.2 break tool installation for some formats Changes in v0.1.1 -> v0.1.2 break tool installation for some name formats Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant