-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing to load rome.properties #130
Comments
=== This comment was migrated from JIRA === Author: buckett Created: Mon Apr 20 13:27:45 CEST 2009 =========================================== Created an attachment (id=34) |
=== This comment was migrated from JIRA === Author: buckett Created: Mon Apr 20 13:29:19 CEST 2009 =========================================== The attached patch fixes rome so it works in Sakai. It allows the classloader to |
=== This comment was migrated from JIRA === Author: anonymous Created: Thu Sep 15 20:55:38 CEST 2011 =========================================== Attachment rome-129.patch has been added with description: rome-129.patch |
Is anyone thinking about testing this patch out? |
This problem is also hit by Apache Nutch (cf. NUTCH-1494 and NUTCH-1893): various documents formats (including feeds) are parsed by plugins, every plugin has its own class loader. The problem is currently worked around by downgrading to rome 0.9. |
Is there anything that needs doing to get this fix into rome? If I created a pull request would that help? |
@lewismc @sebastian-nagel @buckett However you might have problems using Rome in OSGi environment because it's not being packaged as an OSGi bundle. This will be addressed in OSGi-related issues like #143 and #135. |
@mishako @lewismc I can confirm that the problem is fixed when Rome 1.5.1 is used (I didn't test 1.5.0). We are going to upgrade the Rome library dependency, see NUTCH-2193. Thanks! |
Currently we use an old version of rome, rome-fetcher in Sakai
(http://sakaiproject.org) and I was looking as upgrading them to the latest
version to them. Currently Sakai has complicated classloader setup. There is a
description of it here.
https://source.sakaiproject.org/svn/reference/trunk/docs/architecture/sakai_component.doc
Sakai runs ontop of tomcat and each "component" has it's own classloader that
child of the shared classloader. The API for the component goes in shared so
that both the component and any webapp can access. The component then implements
this APi. But the implementation code can't be accessed by the webapp as the
component's classloader isn't a parent of the webapps. This prevents any webapps
accessing anything in a component.
Currently there is an API for getting RSS feeds which is implemented by a
component containing rome. The problem is that when a webapp calls through to
this component the thread classloader is still set to the webapp's so it
attempts to load the master configuration file (rome.properties) from the
webapp. This fails and causes rome to stop working.
It would be useful if PropertiesLoader could use either the thread classloader
or the classloader that loaded PropertiesLoader to load the configuration.
The text was updated successfully, but these errors were encountered: