Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up vocabulary in browse #15

Open
bochocki opened this issue Mar 3, 2017 · 1 comment
Open

Clean up vocabulary in browse #15

bochocki opened this issue Mar 3, 2017 · 1 comment
Assignees

Comments

@bochocki
Copy link
Contributor

bochocki commented Mar 3, 2017

Names should be more intuitive, adhere to the snake_case, and functions should adhere to object_verb() syntax.

We should use "vars" as often as possible (e.g., full_tbl --> all_vars)

Add more descriptive comments, especially to difficult/confusing lines that are currently uncommented.

@bochocki bochocki changed the title Clean up vocabulary in brose Clean up vocabulary in browse Mar 3, 2017
@AldoCompagnoni AldoCompagnoni self-assigned this Mar 9, 2017
@AldoCompagnoni
Copy link
Contributor

AldoCompagnoni commented Mar 13, 2017

Changed function to more intuitive names.
Objects whose name have changed
err_full_tab to vars_spell.
possible_args to possible_vars
possibleargs to possiblevars (in test_browse.R only)
sbst_popler to logic_expr
key_arg to keyword_subset
out_cols to out_vars
elastic_tab to nest_taxa
elastic_data to nested_data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants