Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regularize schema for external ids #53

Open
tgbugs opened this issue Jul 22, 2019 · 0 comments
Open

regularize schema for external ids #53

tgbugs opened this issue Jul 22, 2019 · 0 comments
Labels
data model/schema Changes to ROR data model/schema enhancement Improvement/change to existing functionality external IDs Handling external IDs in ROR

Comments

@tgbugs
Copy link

tgbugs commented Jul 22, 2019

The format of external id records is inconsistent. For example see https://api.ror.org/organizations/05rrcem69
/external_ids/GRID/all is a string for a single entry.
/external_ids/Wikidata/all is a list for a single entry.
I think that /external_ids/*/all should always be a list?

Another potential issue is that the ISNI record does not list a preferred even though there is only a single entry. I don't know whether this is an inconsistency or whether ror is reflecting the underlying semantics of the other identifier systems, e.g. ISNI doesn't list a preferred id if there is only a single entry, or may not list a preferred id at all. In either case it is straight forward to implement a simple rule for dealing with null preferred ids so probably not a schema issue.

@tgbugs tgbugs changed the title regularize returned schema regularize schema for external ids Jul 22, 2019
@mfenner mfenner added this to the Align ROR JSON with GRID milestone Aug 19, 2019
@mariagould mariagould removed this from the Align ROR JSON with GRID milestone May 19, 2020
@mariagould mariagould added data model/schema Changes to ROR data model/schema enhancement Improvement/change to existing functionality external IDs Handling external IDs in ROR labels May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data model/schema Changes to ROR data model/schema enhancement Improvement/change to existing functionality external IDs Handling external IDs in ROR
Projects
Status: Under development
Development

No branches or pull requests

4 participants