ROS_ASSERT_CMD missing parentheses around condition

[b-adkins]

This...

#define ROS_ASSERT_CMD(cond, cmd) \
  do { \
    if (!cond) { /* This line */ \
      cmd; \
    } \
  } while (0)

...should be...

#define ROS_ASSERT_CMD(cond, cmd) \
  do { \
    if (!(cond)) {  /* This line */ \
      cmd; \
    } \
  } while (0)

...like it is in ROS_ASSERT() and ROS_ASSERT_MSG(), so that developers don't have to wrap the cond argument in parentheses themselves.

To reproduce, try to compile a ROS_ASSERT_CMD statement where the !cond would be invalid.

E.g. with the following code...

ROS_ASSERT_CMD(myObject == myObject2, return false);

...the compiler will complain that it can't apply the '!' operator to myObject.

So the developer has to use:

ROS_ASSERT_CMD((myObject == myObject2), return false);

But for the other ASSERT macros he/she can keep the natural form:

ROS_ASSERT(myObject == myObject2);
ROS_ASSERT_MSG(myObject == myObject2, "Objects aren't equal!");