Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: snr_estimate #146

Closed
AhmetCanSolak opened this issue Apr 21, 2022 · 1 comment
Closed

BUG: snr_estimate #146

AhmetCanSolak opened this issue Apr 21, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@AhmetCanSolak
Copy link
Collaborator

Describe the bug
snr estimate tests/demos are broken. @royerloic do you have any ideas what might be wrong?

To Reproduce
To reproduce, one can run the aydin/analysis/demo/demo_snr_estimate.py or the snr estimate test, which is calling the demo file.

Expected behavior
Asserts to execute successfully.

Desktop (please complete the following information):

  • OS: OSX, Ubuntu 20.04]
  • Version: latest master

Additional context
Probably some changes introduced in #144 changed the behavior of the aforementioned part of the code.
@AhmetCanSolak AhmetCanSolak added the bug Something isn't working label Apr 21, 2022
@AhmetCanSolak
Copy link
Collaborator Author

#286 addressed this, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AhmetCanSolak