From 484f24c06dc11df4b48225144ae5e1a07d759e16 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20F=C3=B6hring?= Date: Fri, 5 Jan 2024 08:08:32 +0100 Subject: [PATCH] Fix false positive in MissedMetadataKeyInLoggerConfig Refs #1101 --- .../warning/missed_metadata_key_in_logger_config.ex | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/credo/check/warning/missed_metadata_key_in_logger_config.ex b/lib/credo/check/warning/missed_metadata_key_in_logger_config.ex index a88e4ec45..0d48eb684 100644 --- a/lib/credo/check/warning/missed_metadata_key_in_logger_config.ex +++ b/lib/credo/check/warning/missed_metadata_key_in_logger_config.ex @@ -170,20 +170,13 @@ defmodule Credo.Check.Warning.MissedMetadataKeyInLoggerConfig do metadata_keys = Params.get(params, :metadata_keys, __MODULE__) if metadata_keys == [] do - find_metadata_keys_in_logger_config() || [] + find_metadata_keys_in_logger_config(:default_formatter) || + find_metadata_keys_in_logger_config(:console) || [] else metadata_keys end end - if Version.match?(System.version(), ">= 1.15.0-rc") do - defp find_metadata_keys_in_logger_config(), - do: find_metadata_keys_in_logger_config(:default_formatter) - else - defp find_metadata_keys_in_logger_config(), - do: find_metadata_keys_in_logger_config(:console) - end - defp find_metadata_keys_in_logger_config(key) do :logger |> Application.get_env(key, [])