Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap command with sh -c for node-execute and run-image step #29

Closed
ryancurrah opened this issue Apr 16, 2018 · 0 comments
Closed

Wrap command with sh -c for node-execute and run-image step #29

ryancurrah opened this issue Apr 16, 2018 · 0 comments

Comments

@ryancurrah
Copy link
Contributor

ryancurrah commented Apr 16, 2018

Lately our team has been onboarding new users to Rundeck and we require them to use this plugin instead of local command.

We have been finding users are having trouble running commands like echo "hello" && echo "bye" or echo "export MYVAR=hello" > vars.env' or cat ~/ansible.cfg until they wrap it in bash -c. This is because of docker not this plugin see docker/compose#2033 for more info.

I propose we wrap commands (If one was specified) in sh -c instead of just passing it normally. This will make it easier for newcomers to docker and this plugin while making the steps more readable.

All major shells (csh, ksh, fish, bash) use the same switch -c to pass commands to them.

@ryancurrah ryancurrah changed the title Wrap command with /bin/sh for node-execute and run-image step Wrap command with sh -c for node-execute and run-image step Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant