From b191b41db23716d70b51b0db186237c1f4985d45 Mon Sep 17 00:00:00 2001 From: Alexander Potapenko Date: Tue, 28 Apr 2020 09:47:49 +1000 Subject: [PATCH] fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info() KMSAN reported uninitialized data being written to disk when dumping core. As a result, several kilobytes of kmalloc memory may be written to the core file and then read by a non-privileged user. Link: http://lkml.kernel.org/r/20200419100848.63472-1-glider@google.com Link: https://github.com/google/kmsan/issues/76 Signed-off-by: Alexander Potapenko Reported-by: sam Acked-by: Kees Cook Cc: Alexey Dobriyan Cc: Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index fb769702904669..1a8b0c74f5b0cd 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1729,7 +1729,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t, (!regset->active || regset->active(t->task, regset) > 0)) { int ret; size_t size = regset_size(t->task, regset); - void *data = kmalloc(size, GFP_KERNEL); + void *data = kzalloc(size, GFP_KERNEL); if (unlikely(!data)) return 0; ret = regset->get(t->task, regset,