Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DuplexConnection responsible for returning handshakes #104

Closed
russelltg opened this issue May 16, 2021 · 1 comment · Fixed by #130
Closed

Make DuplexConnection responsible for returning handshakes #104

russelltg opened this issue May 16, 2021 · 1 comment · Fixed by #130
Milestone

Comments

@russelltg
Copy link
Owner

Should be easy, will require thinking about how DuplexConnection sends packets.

@robertream
Copy link
Collaborator

I might agree, but why do you feel this is important? Is it a matter of design esthetics?

Regarding how packets are sent, I was expecting to eventually revisit this, but I want to avoid reintroducing async/await into the protocol code, so absent something like generalized co-routines or effect types becoming available in the language. I suspect that the only way to do this then, is to invert control over the send buffers. This would also have the beneficial effect of getting us one step closer to a potential zero/low allocation implementation suitable for no_std scenarios.

@robertream robertream mentioned this issue Nov 18, 2021
@russelltg russelltg linked a pull request Nov 18, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants