json: Enable "base64" feature #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need base64 encoding in `bitcoin` to in order to stringify the `sign_message::MessageSignature`. Note also that the `Psbt` type is encoded/decoded in base64 and we would like to support that by default also. Enable the "base64" feature unconditionally for the `json` crate.
MSRV build just broke because of a bunch of dependencies. I did not investigate why I just found a set of versions that builds.
|
This is an alternate to #343 |
Oh no that will mean we won't be able to release this for ages, I broke master by merging #326, maybe we should just revert that so we can move on. |
|
Lets merge the revert and get I accept full responsibility for this mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need base64 encoding in
bitcointo in order to stringify thesign_message::MessageSignature.Note also that the
Psbttype is encoded/decoded in base64 and we would like to support that by default also.Enable the "base64" feature unconditionally for the
jsoncrate.(Patch 2 fixes pinning MSRV which is currently broken on master.)