Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(toml): Avoid inferring when targets are known #13849

Merged
merged 2 commits into from
May 2, 2024
Merged

perf(toml): Avoid inferring when targets are known #13849

merged 2 commits into from
May 2, 2024

Commits on May 2, 2024

  1. refactor(toml): Defer inferred discovery

    @epage
    epage committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3740bbb View commit details
    Browse the repository at this point in the history

  2. perf(toml): Avoid inferring when targets are known 

    We read the file system to infer two different data points
- Implicit targets
- Implicit `path` values for targets

I took a shortcut for this case and recognize the scenario where we can
bypass both and do so.
I went with a bypass, rather than this being integrating into the
inferring code because the inferring code is complex and I didn't want
to add to it further in isolating the inferring to only when its needed.
    @epage
    epage committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f5892f2 View commit details
    Browse the repository at this point in the history