refactor: misc refactors for ops::resolve
#13917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a preparation for patch re-resolving.
rustbot
added
A-dependency-resolution
|
@bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2024
Update cargo 6 commits in 4de0094ac78743d2c8ff682489e35c8a7cafe8e4..0de7f2ec6c39d68022e6b97a39559d2f4dbf3930 2024-05-09 16:09:22 +0000 to 2024-05-17 16:54:54 +0000 - Add special `check-cfg` lint config for the `unexpected_cfgs` lint (rust-lang/cargo#13913) - refactor: more comments and variable rename (rust-lang/cargo#13924) - test: set safe.directory for git repo in apache container (rust-lang/cargo#13920) - refactor: misc refactors for `ops::resolve` (rust-lang/cargo#13917) - Preserve file permissions on unix during `write_atomic` (rust-lang/cargo#13898) - Update benchmark formatting for new nightly (rust-lang/cargo#13901) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This is a preparation for another
-Zpatch-filesexperiment,so that the future PR can move things around easier without too many conflicts.
How should we test and review this PR?
Generally they shouldn't affect anything existing behavior.
a6230e3 might be a bit dubious,
though I believe preloading workspace members is kinda idempotent
and registering patches/lockfile never cares about it.
Additional information