test: set safe.directory for git repo in apache container #13920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testing-cargo-itself
weihanglo
force-pushed
the
git-safe-directory
branch
from
813df35
to
2fd4b44
Compare
weihanglo
changed the title
* to git safe.directory for all container tests
|
Thanks! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 18, 2024
Update cargo 6 commits in 4de0094ac78743d2c8ff682489e35c8a7cafe8e4..0de7f2ec6c39d68022e6b97a39559d2f4dbf3930 2024-05-09 16:09:22 +0000 to 2024-05-17 16:54:54 +0000 - Add special `check-cfg` lint config for the `unexpected_cfgs` lint (rust-lang/cargo#13913) - refactor: more comments and variable rename (rust-lang/cargo#13924) - test: set safe.directory for git repo in apache container (rust-lang/cargo#13920) - refactor: misc refactors for `ops::resolve` (rust-lang/cargo#13917) - Preserve file permissions on unix during `write_atomic` (rust-lang/cargo#13898) - Update benchmark formatting for new nightly (rust-lang/cargo#13901) r? ghost
bors
added a commit
that referenced
this pull request
May 22, 2024
[beta-1.79] fix(toml): Don't warn on lints.rust.unexpected_cfgs.check-cfg Beta backports: - #13913 (sort of): removes just the lint warning (in a different way to be minimal) so we reduce warning noise for people using this key on nightly In order to make CI pass, the following PRs are also cherry-picked: - #13865 - #13834 (only `time` due to rust-lang/rust#125319) - #13901 - #13931 - #13920 - #13890 - disable link check (not a cherry pick)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Failure in container tests due to a new version of
gitpackage in Alpine Linux Package repository.See also #13913 (comment)
How should we test and review this PR?
Alpine Linux Package repository 3.19 just bumped git package to 2.43.4 from 2.43.0.
The docker image
httpd:2.4-alpinewe use in container tests failed due to the git version bump.The
httpdlog shown thatgit/git@f4aa8c8 is likely the commit causing problems.
So I ended up adding
git config --system --add safe.directory '*'to the Dockerfile of apache container.Note that we need
--systeminstead of--globalbecausehttpdare running under the other user www-data, not root.