New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build script does not respect RUSTC_WRAPPER #3772

Closed

RalfJung opened this issue Jul 13, 2024 · 0 comments · Fixed by #3842

Labels

C-bug

Member

RalfJung commented Jul 13, 2024 •

edited

Loading

This came up in rust-lang/rust#127682: the build scripts invokes RUSTC without wrapping it in RUSTC_WRAPPER. Bypassing wrappers isn't great, so the build script should be fixed. See cuviper/autocfg#56, djc/rustc-version-rs#46 for similar changes in other crates, and rust-lang/cargo#13659 for the change in cargo.

RalfJung added the C-bug label

RalfJung mentioned this issue

bootstrap: fully rely on RUSTC_WRAPPER rust-lang/rust#127682

Open

RalfJung mentioned this issue

bootstrap should be able to fully rely on RUSTC_WRAPPER rust-lang/rust#128383

Open

tgross35 added the help wanted label

nathaniel-bennett mentioned this issue

Add RUSTC_WRAPPER support to build script #3842

Merged

tgross35 closed this as completed in #3842

RalfJung mentioned this issue

Build script does not honor RUSTC_WRAPPER stepancheg/rust-protobuf#735

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment