Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP_RECVTTL and IPV6_RECVHOPLIMIT for Apple platforms #3450

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

larseggert
Copy link
Contributor

This adds IP_RECVTTL and IPV6_RECVHOPLIMIT for Apple platforms, which are currently missing.

(There are several other socket options present in netinet/in.h and netinet6/in6.h. I didn't add these since my code won't need them. Should I add them anyway?)

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor
Copy link
Member

Thank you! @bors r+

@bors
Copy link
Contributor

bors commented Nov 22, 2023

📌 Commit db7b4be has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 22, 2023

⌛ Testing commit db7b4be with merge 1cc1768...

bors added a commit that referenced this pull request Nov 22, 2023
Add `IP_RECVTTL` and `IPV6_RECVHOPLIMIT` for Apple platforms

This adds `IP_RECVTTL` and `IPV6_RECVHOPLIMIT` for Apple platforms, which are currently missing.

(There are several other socket options present in `netinet/in.h` and `netinet6/in6.h`. I didn't add these since my code won't need them. Should I add them anyway?)
@bors
Copy link
Contributor

bors commented Nov 22, 2023

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Nov 22, 2023

⌛ Testing commit db7b4be with merge 2eec44c...

@bors
Copy link
Contributor

bors commented Nov 22, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 2eec44c to main...

@bors bors merged commit 2eec44c into rust-lang:main Nov 22, 2023
11 checks passed
@larseggert larseggert deleted the feat-ttl branch November 22, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants