Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose solarish's SFV_FD_SELF for sendfilev purpose #3452

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

devnexen
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Nov 25, 2023

Some changes occurred in solarish module

cc @jclulow, @pfmooney

@jclulow
Copy link
Contributor

jclulow commented Nov 25, 2023

I am not sure that this is quite right. Have you been able to get the test suite to pass on an illumos machine?

@devnexen
Copy link
Contributor Author

oddily enough, the test fail for me locally for native_getpwent_r/native_getgrent_t but the linkname setting should prevent that.

@devnexen
Copy link
Contributor Author

test pass now with last test fixes.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 30, 2023

📌 Commit 6fb545a has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 30, 2023

⌛ Testing commit 6fb545a with merge 78079f5...

@bors
Copy link
Contributor

bors commented Nov 30, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 78079f5 to main...

@bors bors merged commit 78079f5 into rust-lang:main Nov 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants