From 948a8f030b51543aedf72188cf8d3ab03d5a3025 Mon Sep 17 00:00:00 2001 From: hkalbasi Date: Wed, 7 Dec 2022 02:29:50 +0330 Subject: [PATCH] Add a fixme comment in current_target_data_layout --- crates/hir-ty/src/layout/target.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/crates/hir-ty/src/layout/target.rs b/crates/hir-ty/src/layout/target.rs index 48b1a68d51b9..b76274bb8548 100644 --- a/crates/hir-ty/src/layout/target.rs +++ b/crates/hir-ty/src/layout/target.rs @@ -24,6 +24,8 @@ pub fn current_target_data_layout_query(db: &dyn HirDatabase) -> Arc 8, }); + // FIXME: These values are incorrect for many architectures, at least for aarch64 and riscv64, + // use `rustc +nightly -Z unstable-options --print target-spec-json` or something similar instead. Arc::new(TargetDataLayout { endian, i1_align: AbiAndPrefAlign::new(Align::from_bytes(1).unwrap()),