From 7d6e58e272c1b1537a67b390615388d94990c790 Mon Sep 17 00:00:00 2001
From: Isaac Bess <isaac.bess@outlook.com>
Date: Mon, 2 Sep 2024 17:12:39 -0700
Subject: [PATCH] Improve "Why is this bad" section and inline `sugg` variable

---
 clippy_lints/src/manual_ilog2.rs | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/clippy_lints/src/manual_ilog2.rs b/clippy_lints/src/manual_ilog2.rs
index ec79b2599dce..06a371026c6b 100644
--- a/clippy_lints/src/manual_ilog2.rs
+++ b/clippy_lints/src/manual_ilog2.rs
@@ -15,7 +15,7 @@ declare_clippy_lint! {
     /// Checks for expressions like `31 - x.leading_zeros()` or `x.ilog(2)` which are manual
     /// reimplementations of `x.ilog2()`
     /// ### Why is this bad?
-    /// It is easier to read and understand
+    /// Manual reimplementations of `ilog2` increase code complexity for little benefit.
     /// ### Example
     /// ```no_run
     /// let x: u32 = 5;
@@ -90,14 +90,13 @@ impl LateLintPass<'_> for ManualIlog2 {
             && let LitKind::Int(Pu128(2), _) = lit.node
             && cx.typeck_results().expr_ty(reciever).is_integral()
         {
-            let sugg = snippet_with_applicability(cx, reciever.span, "..", &mut applicability);
             span_lint_and_sugg(
                 cx,
                 MANUAL_ILOG2,
                 expr.span,
                 "manually reimplementing `ilog2`",
                 "consider using .ilog2()",
-                format!("{sugg}.ilog2()"),
+                format!("{}.ilog2()", snippet_with_applicability(cx, reciever.span, "..", &mut applicability)),
                 applicability,
             );
         }