regression: from_raw_parts is ambiguous

[Mark-Simulacrum]

https://crater-reports.s3.amazonaws.com/beta-1.77-3/beta-2024-02-18/reg/rsubox-0.2.1/log.txt

• cc @luckboy, crate author

My guess is this will be closed as expected, but should be a conscious decision.

[INFO] [stdout] error[E0659]: `from_raw_parts` is ambiguous
[INFO] [stdout]     --> src/utils.rs:1255:65
[INFO] [stdout]      |
[INFO] [stdout] 1255 | ...   version: OsString::from(&OsStr::from_bytes(unsafe { from_raw_parts(libc_name.assume_init_ref().version.as_ptr() as *const u8, versi...
[INFO] [stdout]      |                                                           ^^^^^^^^^^^^^^ ambiguous name
[INFO] [stdout]      |
[INFO] [stdout]      = note: ambiguous because of multiple glob imports of a name in the same module
[INFO] [stdout] note: `from_raw_parts` could refer to the function imported here
[INFO] [stdout]     --> src/utils.rs:39:5
[INFO] [stdout]      |
[INFO] [stdout] 39   | use std::slice::*;
[INFO] [stdout]      |     ^^^^^^^^^^^^^
[INFO] [stdout]      = help: consider adding an explicit import of `from_raw_parts` to disambiguate
[INFO] [stdout] note: `from_raw_parts` could also refer to the function imported here
[INFO] [stdout]     --> src/utils.rs:40:5
[INFO] [stdout]      |
[INFO] [stdout] 40   | use std::str::*;
[INFO] [stdout]      |     ^^^^^^^^^^^
[INFO] [stdout]      = help: consider adding an explicit import of `from_raw_parts` to disambiguate

[asquared31415]

#119466 added the str::from_raw_parts function. I suspect this is expected, std can't be expected to never add any functions ever because it might conflict with something else.

cc #119206 (tracking issue)

[dtolnay]

Relevant documentation: https://doc.rust-lang.org/1.76.0/cargo/reference/semver.html#item-new

"glob imports are a known forwards-compatibility hazard. Glob imports of items from external crates should be avoided."

Normally, unless the breakage is extraordinarily disruptive (affecting a foundational library that is unmaintained but still widely-used) we move on and remind the author not to use glob imports.

[apiraino]

removing the I-prioritize as it looks like expected behaviour (Zulip discussion), so IIUC nothing to see here.

@rustbot label -I-prioritize

[jieyouxu]

Can this issue be closed then if it's intended breakage?

[joshtriplett]

We discussed this in today's @rust-lang/libs meeting. Confirming that this kind of ambiguity is expected behavior when doing multiple glob imports.