Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/ui/treat-err-as-bug/panic-causes-oom-112708.rs is very slow after #121927 #122009

Closed
Zalathar opened this issue Mar 5, 2024 · 3 comments
Closed
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Zalathar
Copy link
Contributor

Zalathar commented Mar 5, 2024

//@ compile-flags: -Ztreat-err-as-bug
//@ dont-check-failure-status
//@ error-pattern: aborting due to `-Z treat-err-as-bug=1`
//@ dont-check-compiler-stderr
//@ rustc-env:RUST_BACKTRACE=0

fn main() {
    #[deny(while_true)]
    while true {}
}

When doing x test ui, I noticed that this particular test now takes a very long time to run. I was able to bisect the change down to #121927.

# BEFORE
$ git checkout cd9e5b5f && x test ui -- panic-causes-oom --force-rerun
...
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 16251 filtered out; finished in 26.35ms

# AFTER
$ git checkout de95c39a && x test ui -- panic-causes-oom --force-rerun
...
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 16251 filtered out; finished in 103.41s

(Notice the jump from milliseconds to seconds.)

@rustbot label +A-testsuite +A-contributor-roadblock +T-compiler

@rustbot rustbot added needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2024
@Zalathar
Copy link
Contributor Author

Zalathar commented Mar 5, 2024

cc @Zoxc

Any idea what's happening here?

@Zoxc
Copy link
Contributor

Zoxc commented Mar 5, 2024

It's running out of memory. It will be fixed by #121993.

@Noratrieb Noratrieb removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Mar 5, 2024
@Zalathar
Copy link
Contributor Author

Zalathar commented Mar 5, 2024

Confirmed fixed by #121993.

@Zalathar Zalathar closed this as completed Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-testsuite Area: The testsuite used to check the correctness of rustc T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants