regression: unwrap on None in ast lowering

[Mark-Simulacrum]

[INFO] [stderr] thread 'rustc' panicked at compiler/rustc_ast_lowering/src/lib.rs:946:56:
[INFO] [stderr] called `Option::unwrap()` on a `None` value
[...]
[INFO] [stderr]   20:     0x7f80622076bd - <rustc_ast_lowering[c375b381c4432908]::LoweringContext>::lower_attrs
[INFO] [stderr]   21:     0x7f806220fadb - <rustc_ast_lowering[c375b381c4432908]::LoweringContext>::lower_assoc_item
[INFO] [stderr]   22:     0x7f806220a1e1 - <rustc_ast_lowering[c375b381c4432908]::item::ItemLowerer>::lower_node
[INFO] [stderr]   23:     0x7f806220c879 - rustc_ast_lowering[c375b381c4432908]::lower_to_hir
[INFO] [stderr]   24:     0x7f806286e1a0 - rustc_query_impl[ad8bed1ffb21e22c]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[ad8bed1ffb21e22c]::query_impl::hir_crate::dynamic_query::{closure#2}::{closure#0}, rustc_middle[16e6156279eb1caf]::query::erase::Erased<[u8; 8usize]>>
[INFO] [stderr]   25:     0x7f8062883b6a - rustc_query_system[4beaed5e390715c6]::query::plumbing::try_execute_query::<rustc_query_impl[ad8bed1ffb21e22c]::DynamicConfig<rustc_query_system[4beaed5e390715c6]::query::caches::SingleCache<rustc_middle[16e6156279eb1caf]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[ad8bed1ffb21e22c]::plumbing::QueryCtxt, false>
[INFO] [stderr]   26:     0x7f8062883782 - rustc_query_impl[ad8bed1ffb21e22c]::query_impl::hir_crate::get_query_non_incr::__rust_end_short_backtrace
[INFO] [stderr]   27:     0x7f8062cda018 - rustc_query_impl[ad8bed1ffb21e22c]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[ad8bed1ffb21e22c]::query_impl::opt_hir_owner_nodes::dynamic_query::{closure#2}::{closure#0}, rustc_middle[16e6156279eb1caf]::query::erase::Erased<[u8; 8usize]>>.warm
[INFO] [stderr]   28:     0x7f8061d9a02d - rustc_query_system[4beaed5e390715c6]::query::plumbing::try_execute_query::<rustc_query_impl[ad8bed1ffb21e22c]::DynamicConfig<rustc_query_system[4beaed5e390715c6]::query::caches::VecCache<rustc_span[5f5e31a6435c6e19]::def_id::LocalDefId, rustc_middle[16e6156279eb1caf]::query::erase::Erased<[u8; 8usize]>>, false, false, false>, rustc_query_impl[ad8bed1ffb21e22c]::plumbing::QueryCtxt, false>
[INFO] [stderr]   29:     0x7f8061d99d09 - rustc_query_impl[ad8bed1ffb21e22c]::query_impl::opt_hir_owner_nodes::get_query_non_incr::__rust_end_short_backtrace
[INFO] [stderr]   30:     0x7f8061e69898 - <rustc_middle[16e6156279eb1caf]::ty::context::TyCtxt>::expect_hir_owner_nodes
[INFO] [stderr]   31:     0x7f8061e649a0 - rustc_middle[16e6156279eb1caf]::hir::map::hir_crate_items

• https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/gh/cyphernet-dao.nsh/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/gh/renostr.renost.rs/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/gh/renostr.renostrd/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/reg/netservices-0.4.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/reg/mpmfnum-0.1.0/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/gh/rust-amplify.io-reactor/log.txt
  • https://crater-reports.s3.amazonaws.com/beta-1.78-3/beta-2024-03-30/reg/io-reactor-0.2.1/log.txt

(and other cases too)

[matthiaskrgr]

might be related to #121537

[compiler-errors]

The PR introducing the regression in this rollup is #121120: Add ErrorGuaranteed to ast::LitKind::Err, `token::LitKi…

searched nightlies: from nightly-2024-01-01 to nightly-2024-03-16
regressed nightly: nightly-2024-02-16
searched commit range: ee9c7c9...a447249
regressed commit: cbddf31

bisected with cargo-bisect-rustc v0.6.8

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc --start=2024-01-01 --end=2024-03-16 -- build 

cc @nnethercote

Maybe check that #121545 fixes this (#121537 (comment)) and we just need to backport that?

[apiraino]

WG-prioritization assigning priority (Zulip discussion).

@rustbot label -I-prioritize +P-critical

[wesleywiser]

@pnkfelix confirms this will be fixed by the backport of #121545

[cuviper]

Backported in #123801.