Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LD_LIBRARY_PATH contains an empty entry during build #52693

Closed
glandium opened this issue Jul 25, 2018 · 3 comments
Closed

LD_LIBRARY_PATH contains an empty entry during build #52693

glandium opened this issue Jul 25, 2018 · 3 comments

Comments

@glandium
Copy link
Contributor

I was looking at the output of x.py with -vv for $reasons, and noticed that commands run with LD_LIBRARY_PATH set to multiple paths, separated with a colon, which is normal, but the last character is a colon, which effectively adds the current working directory in the list of paths used. This is generally considered bad practice.

Cc: @alexcrichton

@ExpHP
Copy link
Contributor

ExpHP commented Jul 25, 2018

Example of how this can cause things to go wrong:

pulldown-cmark/pulldown-cmark#122

@glandium
Copy link
Contributor Author

FWIW, when LD_LIBRARY_PATH is set before running x.py, its original value ends up at the end of the LD_LIBRARY_PATH that had a trailing colon.

@glandium
Copy link
Contributor Author

It looks like it's a cargo issue. Moving there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants